CI(docs.rs): not use --no-deps as a workaround #6065
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marxin
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --no-deps cargo argument to the docs.rs build configuration for all Wasmer library packages as a temporary workaround for a transitive dependency issue (#5823).
Changes:
- Added
cargo-args = ["--no-deps"]to the docs.rs metadata section of 18 library package Cargo.toml files
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/api/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/cache/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/cli/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/compiler/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/compiler-cranelift/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/compiler-llvm/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/compiler-singlepass/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/journal/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/middlewares/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/swift/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/sys-utils/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/types/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/virtual-fs/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/virtual-net/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/vm/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/wai-bindgen-wasmer/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/wasi-types/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
| lib/wasix/Cargo.toml | Added --no-deps cargo argument to docs.rs build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marxin
force-pushed
the
docs.rs-no-deps
branch
from
97407b4 to
8294372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the best workaround for #5823 where we're waiting for a new release of one of our transitive dependency.